Skip to content

chore(deps): update @primer/react to v37#1746

Closed
renovate[bot] wants to merge 1 commit intomainfrom
renovate/primer-react-37.x
Closed

chore(deps): update @primer/react to v37#1746
renovate[bot] wants to merge 1 commit intomainfrom
renovate/primer-react-37.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Jan 20, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
@primer/react 36.27.0 -> 37.31.0 age confidence

Release Notes

primer/react (@​primer/react)

v37.31.0

Compare Source

Permalink to Documentation

Minor Changes

  • #​6470 e53228c Thanks @​copilot-swe-agent! - Add size prop to ActionList.LinkItem component. The size prop accepts 'medium' (default) or 'large' values and provides the same styling options as ActionList.Item for consistent sizing across ActionList components.

  • #​6265 829a933 Thanks @​joshblack! - Update IssueLabel component types to support custom content through children and support the as prop

  • #​6420 024b82a Thanks @​chanakyav! - Adds variant and shape props to AvatarStack component. The variant prop will allow the component to render in a cascade view (by default) or a new stacked view which will evenly space the avatars and remove opacity. The shape prop will allow the avatars to be rendered as circles (by default) or squares.

  • #​4744 3c9e322 Thanks @​TylerJDev! - Address additional ToggleSwitch a11y feedback

  • #​6182 9e49abd Thanks @​TylerJDev! - Textarea: Adds minHeight and maxHeight as props

Patch Changes

v37.30.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.29.1

Compare Source

Patch Changes

v37.29.0

Compare Source

Minor Changes
Patch Changes

v37.28.1

Compare Source

Permalink to Documentation

Patch Changes
  • 1d3aba0 Thanks @​jonrohan! - Fixing an issue where hovering the TabNav will give the tabs outlines.

v37.28.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.27.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.26.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.25.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.24.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.23.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.22.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.21.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.20.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.19.1

Compare Source

Patch Changes

  • Update data table pagination pageEnd to handle zero based index

  • b926c08 Thanks @​AAugustine! - Update data table pagination pageEnd to handle zero based index

v37.19.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.18.0

Compare Source

Permalink to documentation
Minor Changes
Patch Changes

v37.17.0

Compare Source

Permalink to Documentation

Minor Changes

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added the dependency Dependency updates label Jan 20, 2025
setchy
setchy requested changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@setchy setchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When bringing Primer React into your project you will need a bundler setup to be aware of how to handle CSS when imported from a JavaScript context.

See primer/react#5165

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@setchy setchy requested a review from afonsojramos February 6, 2025 15:58
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 4 times, most recently from e637a16 to 5c548bd Compare February 13, 2025 23:33
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 5 times, most recently from d03e23d to 0725eb4 Compare February 21, 2025 19:09
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 4 times, most recently from b3620d6 to 015d1a4 Compare March 4, 2025 13:37
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 3 times, most recently from 80be4f2 to 5b506d1 Compare March 8, 2025 13:47
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 5 times, most recently from 3416e68 to 51da6e3 Compare March 20, 2025 12:17
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 2 times, most recently from d9138ef to e766d01 Compare April 29, 2025 20:44
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 8 times, most recently from 2a58980 to ff85be7 Compare May 9, 2025 20:43
@renovate renovate Bot force-pushed the renovate/primer-react-37.x branch 5 times, most recently from 0d69d4f to 85c9941 Compare May 17, 2025 08:11
@setchy setchy added the help-wanted Extra attention is needed label May 17, 2025
@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented May 27, 2025

@setchy do you need help with this too?

@setchy
Copy link
Copy Markdown
Member

setchy commented May 27, 2025

@setchy do you need help with this too?

Help would be great. I've had a few timeboxed attempts. The experimental primer Banner component is giving some headaches

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented May 27, 2025

@setchy do you need help with this too?

Help would be great. I've had a few timeboxed attempts. The experimental primer Banner component is giving some headaches

Do we use some component which need to be replaced with Banner, or they implemented some breaking changes?

@setchy
Copy link
Copy Markdown
Member

setchy commented May 27, 2025

primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change

Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithOAuthApp.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithPersonalAccessToken.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented May 27, 2025

primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change

Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithOAuthApp.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithPersonalAccessToken.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

Thank you for clarification, I will check

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented May 29, 2025

@setchy I checked it.

  1. experimental path was fixed by changing both module and moduleResolution to 'nodenext'
  2. They are moving away from styled-components in favor of CSS Modules, so probably styling and self-written components will require refactoring.
  3. Self-written components like Tooltip currently breaking the app, so I will try to fix/rewrite them, or adapt similar components from premier

What do you think about it?

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented May 29, 2025 •
edited
Loading

@setchy I checked it.

  1. experimental path was fixed by changing both module and moduleResolution to 'nodenext'
  2. They are moving away from styled-components in favor of CSS Modules, so probably styling and self-written components will require refactoring.
  3. Self-written components like Tooltip currently breaking the app, so I will try to fix/rewrite them, or adapt similar components from premier

What do you think about it?

Nevermind, it was not because of self written tooltip, I almost fixed it and will push later, need some time to test locally and investigate strange issues

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented Jun 1, 2025 •
edited
Loading

@setchy I will close this PR because I cannot push my changes here or create a PR
EDIT: I cannot close it, fix pls

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented Jun 1, 2025

@setchy I will close this PR because I cannot push my changes here or create a PR
EDIT: I cannot close it, fix pls

FYI about changes, for some reason most of the paddings or sizes increased twice, so I manually decreased them, unfortunately have not found root cause or how to avoid such issue clearly

@setchy
Copy link
Copy Markdown
Member

setchy commented Jun 1, 2025 •
edited
Loading

@setchy I will close this PR because I cannot push my changes here or create a PR
EDIT: I cannot close it, fix pls

Thanks for taking a look...

I'll be leaving this PR open since the major upgrade is still required...

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented Jun 1, 2025

@setchy I will close this PR because I cannot push my changes here or create a PR
EDIT: I cannot close it, fix pls

Thanks for taking a look...

I'll be leaving this PR open since the major upgrade is still required...

Ok, then I will push it to another branch)
I asked to close it so I can create with the same branch name, because I already did it locally, but cannot push here because of 403

@SiriusCrain
Copy link
Copy Markdown
Contributor

SiriusCrain commented Jun 1, 2025

All of the changes are ready for review btw, for some reason when I push it to my fork it is not asking to create PR, maybe because branch name is already used here

@setchy
Copy link
Copy Markdown
Member

setchy commented Sep 10, 2025

replaced by #2221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@setchy setchy setchy requested changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees

@afonsojramos afonsojramos

Labels

blocked Is blocked by another issue or dependency dependency Dependency updates help-wanted Extra attention is needed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SiriusCrain @setchy @afonsojramos